GH-119: Updated repository sources and page content - #121
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR restructures the repository by removing/migrating legacy artifacts, updating licensing/copyright metadata, and adding automation to enforce PR/branch conventions tied to GitHub issues.
Changes:
- Removed legacy build/docs/tooling files and updated submodule paths to live under
.github/legacy/. - Updated LICENSE and GitHub Pages site copyright content.
- Added PR/branch validation automation (GitHub Action + local pre-push hook) for
GH-<issue>conventions.
Reviewed changes
Copilot reviewed 14 out of 44 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| var/casm-test | Removed legacy test runner script from var/. |
| var/casm-benchmark | Removed legacy benchmark runner script from var/. |
| var/README.org | Removed legacy var/ documentation stub. |
| ext/README.org | Removed legacy ext/ documentation stub. |
| app/README.org | Removed legacy app/ documentation stub. |
| LICENSE | Updated copyright year metadata. |
| Doxyfile | Removed Doxygen configuration (legacy docs tooling). |
| CMakeLists.txt | Removed legacy CMake build entrypoint. |
| .ycm_extra_conf.py | Removed YouCompleteMe configuration (legacy editor tooling). |
| .gitmodules | Redirected submodule working directories into .github/legacy/. |
| .github/workflows/github-autolink-pr-to-issues.yaml | Added workflow to validate branch/PR naming and verify linked issue existence. |
| .github/pages/content/site/notice.md | Updated site notice copyright year and wording around legacy code licensing. |
| .github/pages/config.toml | Updated footer copyright year. |
| .githooks/pre-push | Added local pre-push hook enforcing branch naming convention. |
| .clang-format | Removed clang-format configuration (legacy tooling/config). |
Comments suppressed due to low confidence (4)
.github/workflows/github-autolink-pr-to-issues.yaml:1
- The branch-name validation error message concatenation is missing a newline (or separator) between the example and the allowed-types text, which will render as a single run-on line. Add a trailing
\\n(or similar separator) after the example string so the output is readable.
.github/workflows/github-autolink-pr-to-issues.yaml:1 - Because this workflow runs on
opened,edited,synchronize, andreopened, it will post a new 'Validation Passed' PR comment on every update, creating noise/spam on active PRs. Consider making the success path non-commenting (e.g., workflow summary), or only commenting once by searching for an existing bot comment and updating it (or skipping if already present), or restricting commenting toopened/reopenedonly.
LICENSE:1 - If
sea-exception-1.0is intended to be an SPDX exception identifier, many license scanners will treat this as invalid unless the exception is registered in the SPDX exception list. If it’s a project-specific exception, consider using SPDX’s custom identifier form (e.g.,WITH LicenseRef-sea-exception-1.0) and ensure the exception text is included in the repository in a clearly referenced location.
.gitmodules:1 - The submodule name (
app/casmc) no longer matches its configuredpath(.github/legacy/casmc), which can be confusing when working with submodules (e.g., during status/debugging and in tooling that displays submodule names). Consider renaming the submodule section header to reflect the new path (for consistency), e.g.,[submodule \".github/legacy/casmc\"].
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🤖 Validation Passed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
.github/legacy/folderLICENSEinformationGH-<issue-number>commit style referencing, see [1]References