tool: fix regression from bde5eb#485
Merged
Ivan-Velickovic merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
I wrongly assumed that the kernel started at a 2MB alignment and so for certain platforms (particularly, the Raspberry Pi 4B), this assert goes off. We do not need this assert since it is expected the kernel is not always 2MB aligned. The loader code still always uses 2MB pages for mapping the kernel, however it will round down to the nearest 2MB alignment which is why this hasn't been an issue previously. This logic follows what the kernel does for its own mappings as well. Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
midnightveil
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrongly assumed that the kernel started at a 2MB alignment and so for certain platforms (particularly, the Raspberry Pi 4B), this assert goes off.
We do not need this assert since it is expected the kernel is not always 2MB aligned. The loader code still always uses 2MB pages for mapping the kernel, however it will round down to the nearest 2MB alignment which is why this hasn't been an issue previously. This logic follows what the kernel does for its own mappings as well.