Skip to content

🧪 Stabilize AGY cancellation cleanup test - #158

Merged
sdougbrown merged 1 commit into
mainfrom
issue/150-stabilize-agy-cancel-test
Aug 5, 2026
Merged

🧪 Stabilize AGY cancellation cleanup test#158
sdougbrown merged 1 commit into
mainfrom
issue/150-stabilize-agy-cancel-test

Conversation

@sdougbrown

Copy link
Copy Markdown
Owner

Summary

  • remove the race-prone post-cancellation prompt assertion
  • wait for the original prompt cleanup before checking for duplicate terminal events
  • replace the timing-based wait with a deterministic nonblocking check

Closes #150

Testing

  • GOCACHE=$PWD/.gocache GOMODCACHE=$PWD/.gomodcache go test -race ./internal/runtime/agy -run '^TestProviderCancelEmitsOneTerminalEvent$' -count=100\n- GOCACHE=$PWD/.gocache GOMODCACHE=$PWD/.gomodcache go test ./...

@umpire-bot umpire-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is marked... HOME RUN! ⚾🎉

@sdougbrown
sdougbrown merged commit 8d895fe into main Aug 5, 2026
4 checks passed
@sdougbrown
sdougbrown deleted the issue/150-stabilize-agy-cancel-test branch August 5, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stabilize AGY cancellation cleanup test ordering

1 participant