ci: install codecov CLI from PyPI to avoid flaky keybase.io key fetch#1204
Closed
timtreis wants to merge 3 commits into
Closed
ci: install codecov CLI from PyPI to avoid flaky keybase.io key fetch#1204timtreis wants to merge 3 commits into
timtreis wants to merge 3 commits into
Conversation
The codecov CLI binary GPG signature was verified against Codecov's old Keybase key (codecovsecurity), which they bricked after migrating to codecovsecops. codecov-action@v5 still uses the old key, so the upload step fails with "Could not verify signature" and, because fail_ci_if_error is true, hard-fails the Coverage job. codecov-action v6.0.2 ships the updated key (a verbatim copy of v7, published by the maintainer for exactly this transition). Pinning @v6 picks it up while staying on the smaller, non-breaking major. Refs: codecov/codecov-action#1956 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
codecov-action@v6 still imports the signing key from keybase.io at runtime (codecov.sh: curl https://keybase.io/codecovsecops/pgp_keys.asc). keybase.io is unreliable; when that fetch times out the GPG verification fails with "no valid OpenPGP data found" and, with fail_ci_if_error true, hard-fails the Coverage job. use_pypi: true installs the CLI from PyPI instead of downloading it from cli.codecov.io, skipping the keybase key fetch entirely while still sourcing the CLI from a trusted channel. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1204 +/- ##
=======================================
Coverage 75.32% 75.32%
=======================================
Files 56 56
Lines 7936 7936
Branches 1295 1295
=======================================
Hits 5978 5978
Misses 1447 1447
Partials 511 511 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1203.
codecov-action@v6fixed the bricked-key problem, but the action still imports the signing key from keybase.io at runtime (codecov.sh:curl https://keybase.io/codecovsecops/pgp_keys.asc). keybase.io is unreliable - when that fetch times out the GPG step fails withno valid OpenPGP data found, and withfail_ci_if_error: truethe Coverage job hard-fails. Seen on #1117's run: https://github.com/scverse/squidpy/actions/runs/27140601219/job/80104717511use_pypi: trueinstalls the CLI from PyPI instead ofcli.codecov.io, skipping the keybase key fetch entirely while still sourcing the CLI from a trusted channel.Ref: codecov/codecov-action#1956