fix: use correct sb3 shadow types for numeric vs string inputs#2
Open
shx20140617 wants to merge 2 commits into
Open
fix: use correct sb3 shadow types for numeric vs string inputs#2shx20140617 wants to merge 2 commits into
shx20140617 wants to merge 2 commits into
Conversation
- Treat numbers and booleans as literal values (convert to string) instead of trying to serialize them as reporter blocks
- Number literals use [4, ...] (math_number shadow) instead of [10, ...] (text shadow) - Reporter blocks detect numeric opcodes (operator_*, data_lengthoflist, etc.) and use [4, ''] shadow - String/boolean literals continue using [10, ...] shadow - Prevents gray non-editable inputs in list index access and math operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Number literals now use [4, ...] shadow (math_number) instead of [10, ...] (text). Reporter blocks detect numeric opcodes (operator_*, data_lengthoflist, etc.) and use [4, ''] shadow. Handles numeric/boolean primitive values in serializeInput(). This prevents gray non-editable inputs in list index access and math operations.