fix: handle namespace extern declarations and use correct operator input names#1
Open
shx20140617 wants to merge 2 commits into
Open
fix: handle namespace extern declarations and use correct operator input names#1shx20140617 wants to merge 2 commits into
shx20140617 wants to merge 2 commits into
Conversation
- Add extraction of extern declarations from 'name = { opcode, type, args }' assignments inside namespace/module bodies
- Properly handle field-type arguments with menu properties
- Add getProgramInfo function, Namespace type, and mergeNamespace helper
- listReps insert/at/replace methods now use NUM1/NUM2 instead of VALUE1/VALUE2 - listReps indexOf method now uses NUM1/NUM2 for operator_subtract - varReps at method now uses NUM1/NUM2 for operator_add - Aligns with Scratch sb3 format where arithmetic operators use NUM1/NUM2 inputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Add AssignmentStatement handling in extractDeclarations() to register extern definitions from name = { opcode, type, args } assignments inside namespace/module bodies. Add getProgramInfo(), Namespace type, mergeNamespace() exports. Change all VALUE1/VALUE2 to NUM1/NUM2 in list/string helper methods to match Scratch sb3 format for arithmetic operators.