Skip to content

fix: make debouncer syncronous if there's no running loop - #603

Merged
jokasimr merged 4 commits into
mainfrom
fix-508
Aug 10, 2026
Merged

fix: make debouncer syncronous if there's no running loop#603
jokasimr merged 4 commits into
mainfrom
fix-508

Conversation

@jokasimr

@jokasimr jokasimr commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Fixes #508

@jokasimr
jokasimr requested a review from nvaytet August 7, 2026 13:22

@nvaytet nvaytet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually in a notebook, seems to work as before 👍

elapsed since the last time it was invoked.

From:
https://ipywidgets.readthedocs.io/en/8.0.2/examples/Widget%20Events.html#Debouncing

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old code was copied from an ipywidgets example.
Did you write the new code yourself or did you get it from somewhere? Can we put a new reference? Was it 'inspired by the ipywidgets example and adapted via LLM'?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a reference for it, the code was generated by codex, but it looks pretty "generic" so I don't really think it needs a reference. What do you think?

Comment thread src/plopp/widgets/clip3d.py Outdated
Comment thread src/plopp/widgets/clip3d.py Outdated
jokasimr and others added 3 commits August 10, 2026 09:41
Co-authored-by: Neil Vaytet <39047984+nvaytet@users.noreply.github.com>
Co-authored-by: Neil Vaytet <39047984+nvaytet@users.noreply.github.com>
@jokasimr
jokasimr merged commit 59c797e into main Aug 10, 2026
5 checks passed
@jokasimr
jokasimr deleted the fix-508 branch August 10, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_move_cut fails on Python 3.14

2 participants