Fix ROI request color selection having no effect - #1246
Merged
Conversation
Member
Author
|
LGTM |
Rectangles and Polygons are fillable glyphs, so HoloViews maps a bare `color` opt to fill_color. Since the ROI request shapes are drawn with fill_alpha=0 so the image underneath stays visible, the configured color only ever reached the invisible fill and the outline stayed at Bokeh's black default. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
SimonHeybrock
force-pushed
the
roi-color-selection
branch
from
August 21, 2026 07:17
f318168 to
f2e0c29
Compare
SimonHeybrock
enabled auto-merge
August 21, 2026 07:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The color picked for ROI request rectangles and polygons had no effect — the shapes always rendered with a black outline.
hv.Rectanglesandhv.Polygonsare fillable glyphs, so HoloViews maps a barecoloropt tofill_colorand leavesline_colorat Bokeh's black default. The ROI request shapes are deliberately drawn withfill_alpha=0so the detector image underneath stays visible, so the configured color only ever reached the invisible fill. Settingline_colorinstead fixes both geometry types. The readback plotters already did this correctly; the request plotters were the odd one out.Test plan
Regression test renders both plotters to Bokeh and asserts the glyph's
line_colormatches the configured color.