Bound the Playwright apt step and make it non-fatal - #1241
Merged
Conversation
A stalled Ubuntu apt mirror hung `playwright install-deps chromium` for 29 minutes on 2026-08-19, and the browser job was cancelled by its 30-minute timeout before it ever reached the tests. Two PRs went red for a reason unrelated to their contents. The step is worth far less than the budget it can consume: on ubuntu-24.04 it installs fonts only (9 packages, all fonts-*/xfonts-*), because the runner image already carries chromium's shared libraries. Bound it to three minutes and let the job proceed on failure with a warning annotation; the browser tests assert laid-out frame geometry, not glyph rendering, so missing CJK fonts cannot change their outcome. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stalled Ubuntu apt mirror hung
playwright install-deps chromiumfor 29 minutes this morning, and the browser job was cancelled by its 30-minute timeout before it ever reached the tests. #1240 and #1238 both went red for a reason unrelated to their contents;mainwould have failed the same way, since the step runs before any repo code is touched.That step is worth far less than the budget it can consume. On
ubuntu-24.04it installs fonts and nothing else -- 9 packages, allfonts-*/xfonts-*, per the last green run -- because the runner image already carries chromium's shared libraries. So it is bounded to three minutes here, and the job proceeds on failure with a warning annotation rather than burning the full timeout. The browser tests assert laid-out frame geometry against a 50px collapse threshold, not glyph rendering, so absent CJK fonts cannot change their outcome.This does not make a genuinely missing dependency silent: chromium failing to launch still fails the browser tests, just with the real error instead of a cancellation.
Test plan
The failure mode is external and cannot be reproduced on demand. Verified instead:
ci.ymlparses, and the step resolves to the intended shell snippetbash -ewhen the command fails, and gives up after the timeout rather than hanginginstall-depsstep still installs the fonts normally