Device-implemented Settings fields#78
Merged
Merged
Conversation
…rent, rather SciFi-specific settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The old specification for settings was rather SciFi-specific. It assumed the notion of name, time source, and FPGA clock frequency were valid notions for all Synapse devices, which could be true, but it could also just be generalized. This generalization will likely especially be appreciated once we implement PRIMA as a Synapse device.
This change makes settings defined by the device with the schema for each field returned as part of the GetSettingsResponse.
Changes
Testing
Note that up-to-date clients asking out-of-date SciFis will show that the SciFi has no settings. People will need to update their SciFis. I can make the clients backwards compatible, but that will be a little ugly: will either have to keep the old fields in DeviceSettings, or will have to put legacy protos in all of our clients.