Skip to content

Fix shell phase hang during oh-my-zsh install #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schultz-dev0 merged 2 commits into from
Jun 19, 2026
Merged

Fix shell phase hang during oh-my-zsh install #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af150da
Fix non-interactive shell setup in installer
Copilot Jun 19, 2026
6787a3a
Fix chsh output redirection in shell phase
Copilot Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions install/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ phase_shell() {
fi

if [[ "$SHELL" != "$zsh_path" ]]; then
if chsh -s "$zsh_path" 2>/dev/null; then
if sudo chsh -s "$zsh_path" "$USER" >/dev/null 2>/dev/null; then
log_ok "Default shell set to zsh (takes effect on next login)."
else
log_warn "chsh failed — run: chsh -s ${zsh_path}"
Expand All @@ -195,13 +195,21 @@ phase_shell() {
local omz_dir="${HOME}/.config/zsh/oh-my-zsh"
if [[ ! -d "$omz_dir" ]]; then
log "Installing oh-my-zsh..."
if ZSH="$omz_dir" RUNZSH=no CHSH=no \
sh -c "$(curl -fsSL https://raw.githubusercontent.com/ohmyzsh/ohmyzsh/master/tools/install.sh)" \
"" --unattended 2>/dev/null; then
log_ok "oh-my-zsh installed."
local omz_installer
omz_installer="$(mktemp)"
if curl -fsSL --connect-timeout 10 --max-time 30 \
https://raw.githubusercontent.com/ohmyzsh/ohmyzsh/master/tools/install.sh \
-o "$omz_installer"; then
if ZSH="$omz_dir" RUNZSH=no CHSH=no \
sh "$omz_installer" "" --unattended 2>/dev/null; then
log_ok "oh-my-zsh installed."
else
log_warn "oh-my-zsh install failed — run manually: ZSH=${omz_dir} sh <(curl -s https://raw.githubusercontent.com/ohmyzsh/ohmyzsh/master/tools/install.sh)"
fi
else
log_warn "oh-my-zsh install failed — run manually: ZSH=${omz_dir} sh <(curl -s https://raw.githubusercontent.com/ohmyzsh/ohmyzsh/master/tools/install.sh)"
fi
rm -f "$omz_installer"
else
log_ok "oh-my-zsh already installed."
fi
Expand Down