fix: add RestrictedUnpickler to prevent arbitrary code execution#226
Open
muhamedfazalps wants to merge 1 commit into
Open
fix: add RestrictedUnpickler to prevent arbitrary code execution#226muhamedfazalps wants to merge 1 commit into
muhamedfazalps wants to merge 1 commit into
Conversation
The code uses pickle.load() without validation, which allows arbitrary code execution if an attacker can modify the .pkl file. Added RestrictedUnpickler that only allows safe modules (numpy, sklearn, builtins). --- If this helps, consider buying me a coffee: https://buymeacoffee.com/muhamedfazalps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix: Unsafe Deserialization
Vulnerability
Root Cause
pickle.load()is used without validation, allowing arbitrary code execution if an attacker can modify the .pkl file in the data directory.Fix
Added
RestrictedUnpicklerthat only allows safe modules (numpy, sklearn, builtins). This prevents arbitrary code execution while maintaining functionality.Testing
If this helps, consider buying me a coffee: https://buymeacoffee.com/muhamedfazalps