port to @scanii/core, bump Lambda runtime to nodejs24.x#107
Merged
Conversation
- Replace bespoke axios-based client (with retry logic) with @scanii/core - Drop axios, serialize-javascript, sinon from deps - Remove MAX_ATTEMPTS / MAX_ATTEMPT_DELAY_MSEC config (no retry per SDK principles) - Bump Lambda runtime from nodejs20.x to nodejs22.x Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Keep the existing retry logic as a local wrapper in lib/client.js that delegates to @scanii/core's ScaniiClient. Restores MAX_ATTEMPTS / MAX_ATTEMPT_DELAY_MSEC config and the retry unit tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add cases for: success on first attempt, success after one transient failure, exhausted attempts with correct count, and maxAttempts respected across N failures. Use maxAttemptDelay=0 to keep tests instant. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- pr.yaml → pr.yml: add concurrency cancel, multi-OS matrix (ubuntu/macos/windows), node 22+24, npm ci - main.yaml → release.yml: trigger on release published instead of push to main; bump node to 24; add header comment Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
node_modules/mocha/bin/_mocha is not executable on Windows; npm scripts add node_modules/.bin to PATH so the mocha alias works cross-platform. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/client.js(which had retry logic violating SDK Principle 3) with@scanii/core1.1.0axios,serialize-javascript, andsinonfrom dependenciesMAX_ATTEMPTS/MAX_ATTEMPT_DELAY_MSECconfig (no retry)nodejs20.x→nodejs24.xintemplate.ymlTest plan
npm test— 25 passing locally🤖 Generated with Claude Code