feat(applets): require SCC authorization for PPE applets#454
Open
tomas-goncalves wants to merge 1 commit intosc0v:masterfrom
Open
feat(applets): require SCC authorization for PPE applets#454tomas-goncalves wants to merge 1 commit intosc0v:masterfrom
tomas-goncalves wants to merge 1 commit intosc0v:masterfrom
Conversation
PPE collection and distribution both create/update Checkout and Tool records, which are SCC-only operations per the Ability model. Neither controller had any authorization check. Added before_action :require_scc using authorize! consistent with the push_broadcast applet pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authorize! :update, Checkout) and distribution (authorize! :create, Checkout) were missing authorization checks despite performing SCC-only operationspush_broadcastpattern (before_action :require_scc)Test plan
/ppe-collectionand/ppe-distribution