chore(release): register spring-boot-morphium README for version bumps - #305
Merged
sboesebeck merged 1 commit intoAug 17, 2026
Merged
Conversation
Follow-up Stephan flagged when merging sboesebeck#299: spring-boot-morphium/README.md was missing from release.sh's MODULE_README_FILES, so it would have kept pinning a stale SNAPSHOT version on every future release cycle -- exactly what this array exists to prevent for the other two extension modules. While verifying the fix actually bumps correctly (not just registering the file and assuming it works), found two things the existing sed patterns in bump_module_readme_snapshots() would not have matched even now: - The "In the Morphium reactor, ... currently resolves to `X-SNAPSHOT`." sentence has "resolves to" between "currently" and the version, but the pattern is `currently [0-9]+\.[0-9]+\.[0-9]+-SNAPSHOT` -- no wildcard for words in between. Reworded to "... is currently X-SNAPSHOT." (matching the working phrasing already used elsewhere) so the pattern actually fires. - The prerequisites table's Morphium row still said "6.2.2" -- stale from before this module tracked the reactor version in lockstep, and in a format the "| Morphium | X-SNAPSHOT" pattern doesn't match either. Updated to the same "X-SNAPSHOT (built in lockstep as part of the reactor)" phrasing quarkus-morphium/README.md already uses successfully. Verified end to end: copied the file, ran the exact three sed substitutions bump_module_readme_snapshots() uses with a fake target version, confirmed all four SNAPSHOT-bearing lines updated correctly, restored the original (byte-identical, confirmed via diff) before committing the real fix.
Owner
|
Thanks - all good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from your #299 approve comment:
spring-boot-morphium/README.mdwas missing fromMODULE_README_FILESinrelease.sh.While wiring it in, verified the bump actually fires end-to-end rather than assuming registration alone is enough — found two phrasings in the README that wouldn't have matched the existing
sedpatterns even with the file registered:X-SNAPSHOT" has words between "currently" and the version; the pattern has no wildcard for that. Reworded to "... is currently X-SNAPSHOT.", matching the phrasing that already works inmorphium-jakarta-data/README.md.| Morphium | X-SNAPSHOTshape the pattern expects either. Updated to the same "X-SNAPSHOT (built in lockstep as part of the reactor)" phrasingquarkus-morphium/README.mduses.Verified by copying the file, running the three real
sedsubstitutions frombump_module_readme_snapshots()with a fake target version, confirming all four SNAPSHOT-bearing lines update, then restoring byte-identical (diff-confirmed) before committing the actual fix.