fix: sas9 public access denied handling#755
Open
medjedovicm wants to merge 6 commits into
Open
Conversation
Coverage reportTotal coverage
Show files with reduced coverage 🔻Reduced coverage
Report generated by 🧪jest coverage report action from 3556eb3 |
Member
|
@medjedovicm please a test cases for both scenarios |
YuryShkoda
approved these changes
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #150
Intent
Covers the SAS9
Public Access Deniedscenario. 2 places touched:login()- User is not logged in. The login function is called withPublic Accountcredentials. The adapter will return an object that contains an error message with error details andloggedInis false. (image 1.)request()- User withPublic Accountis already logged in within current browser. App loads,requestfunction is called. The adapter will throw an error with details inside. (image 2.)image 1.

image 2.

Checks
No PR (that involves a non-trivial code change) should be merged, unless all items below are confirmed! If an urgent fix is needed - use a tar file.
sasjs-cliunit tests are passing (npm test).sasjs-testsare passing. If you want to run it manually (instructions available here).