fix(core): group verified well-known skill sources - #67
Merged
Conversation
santosli
force-pushed
the
codex/import-lark-collection-detection
branch
from
August 30, 2026 01:57
20b1a47 to
5fe3efe
Compare
santosli
marked this pull request as ready for review
August 30, 2026 02:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sourceType=well-knowninstaller provenance as a display-only Installed Source CollectionsourceBaseUrl; keep live Git precedence, singleton behavior, snapshots, type/status/conflict handling, and per-skill apply unchangedRoot cause and local reconciliation
The parser accepted only
sourceType=github, so valid well-known entries were rejected before candidate matching. Aggregate-only local verification after the fix reports 70 candidates, one lockfile scanned, 65 validated/matched entries, six invalid entries, three installed-source collections, and exactly oneopen.feishu.cncollection with 28 children and zerolark-*standalone groups. No local paths or skill contents were logged.Trust boundary
sourceTypemust be exactlywell-known<normalized-base>/.well-known/skills/<validated-name>/SKILL.mdVerification
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo test --offline: 458 passednpm test: 280 passednpm --workspace apps/desktop run buildnpm audit --audit-level=high: 0 vulnerabilitiescargo audit: no vulnerabilities; 18 repository-policy warningsgit diff --checkVisual QA
/tmp/skillbox-lark-installed-source-collapsed-1600.png(1600x900)/tmp/skillbox-lark-installed-source-expanded-1600.png(1600x900)/tmp/skillbox-lark-installed-source-expanded-1000.png(1000x760)The privacy-safe deterministic QA fixture used the production Installed Source Collection component with Lark-shaped names and was restored before commit. At 1000px the dialog is 936px wide, the collection is 898px wide, and page
scrollWidthequals 1000px with no horizontal overflow. The real child count/grouping evidence comes from the aggregate Rust scan above.This PR is independent of Draft PR #66 and contains none of its collection-header layout changes.