docs(impl): isolate global HIR type validation - #676
Merged
Conversation
sanohiro
marked this pull request as ready for review
July 30, 2026 17:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review closure
The initial post-open reviews found that the broader plan omitted per-position type admissibility and the complete logical/emitted/generated callable namespace, and that exact compiler-symbol rejection would silently change current source acceptance. The plan was reopened rather than patched: none of those surfaces is authorized for implementation by this PR.
The fresh rescope review found one root-predicate ambiguity. The final contract now makes every non-template tagged/function node a concrete root and excludes only the transitive Param-dependent abstract template graph. That finding is closed and the final review is clean.
Verification
git diff --check origin/main...HEADscripts/pre-pr.shHEAD/base-bound attestation