fix(mir): close eager continuation lowering - #675
Merged
Conversation
sanohiro
marked this pull request as ready for review
July 30, 2026 13:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
map_err, and owned-string field viewsVerification
scripts/pre-pr.sh(includesscripts/test-pr.shand workspace/all-target Clippy with warnings denied)cargo test -p align_mircargo test -p align_driver --test mir_continuationcargo test -p align_driver --test expr_depth within_limit_chain_compiles_and_runscargo test -p align_driver --test per_unit_codegen eager_expression_terminationThe full
expr_depthbinary still reproduces its unchanged sema-timedeep_within_limit_expression_is_acceptedstack overflow onorigin/mainunder local Rust 1.96.1. The MIR-owned depth target above passes, and the debuglower_exprframe improves from 77,168 to 75,808 bytes.Benchmark
Apple Silicon provenance fixture:
Review closure
The post-open review cycle inspected the complete pushed diff at
d2fa63425dc1a5e8754c8c93ddd168eee3ae22d6. Its one valid finding was fixed in the final follow-up: malformed dynamic/SoA field metadata is now rejected beforeSliceLenor any field action. The malformed-metadata owner test, fullalign_mirtests, MIR-continuation driver tests, string-view and SoA owners, andalign_mirClippy pass. Per repository policy and explicit user direction, this bounded P2 fix was closed by the finding-to-fix ledger; no second full-diff review was run.