fix(visual-editing-standalone): drop types condition for styles.css - #3632
fix(visual-editing-standalone): drop types condition for styles.css#3632stipsan wants to merge 2 commits into
Conversation
The sibling dist/styles.css.d.ts is enough for TypeScript to type the plain string ./styles.css export. Restore css.exports: true and drop the customExports wrapper. Co-authored-by: Cody Olsen <stipsan@users.noreply.github.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
9 Skipped Deployments
|
A sibling dist/styles.css.d.ts types relative CSS imports, not package exports subpaths. Without a types condition, tsc and oxlint fail with TS2307 on import '@sanity/visual-editing-standalone/styles.css'. Co-authored-by: Cody Olsen <stipsan@users.noreply.github.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Follow-up to #3630 that tried to drop the
typescondition on./styles.css, keeping only the siblingdist/styles.css.d.ts.That does not type-check. Through
package.json"exports", TypeScript does not pick upstyles.css.d.tsnext to the stylesheet.pnpm lint(oxlint) andtscfail with:The last commit restores the
typescondition from #3630 so CI can pass. Net diff vsmainis empty — this PR should be closed rather than merged. #3630 is the working fix.