fix(mcp): use oauth for codex cli config#1151
Open
runeb wants to merge 1 commit into
Open
Conversation
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (e051d47) |
|---|---|---|
| Internal (raw) | 2.1 KB | - |
| Internal (gzip) | 799 B | - |
| Bundled (raw) | 10.97 MB | - |
| Bundled (gzip) | 2.06 MB | - |
| Import time | 842ms | +2ms, +0.2% |
bin:sanity
| Metric | Value | vs main (e051d47) |
|---|---|---|
| Internal (raw) | 1023 B | - |
| Internal (gzip) | 486 B | - |
| Bundled (raw) | 9.87 MB | - |
| Bundled (gzip) | 1.77 MB | - |
| Import time | 1.95s | -6ms, -0.3% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (e051d475)
| Metric | Value | vs main (e051d47) |
|---|---|---|
| Internal (raw) | 96.3 KB | - |
| Internal (gzip) | 22.7 KB | - |
| Bundled (raw) | 21.64 MB | - |
| Bundled (gzip) | 3.43 MB | - |
| Import time | 797ms | -4ms, -0.5% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against main (e051d475)
| Metric | Value | vs main (e051d47) |
|---|---|---|
| Internal (raw) | 908 B | - |
| Internal (gzip) | 483 B | - |
| Bundled (raw) | 931 B | - |
| Bundled (gzip) | 491 B | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
Contributor
Coverage Delta
Comparing 1 changed file against main @ Overall Coverage
|
jonahsnider
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes
Codex CLIan OAuth-only editor insanity mcp configure, so it no longer embeds a Sanity API token and instead relies on Codex's own OAuth flow (which now has improved auth messaging). Mirrors the same change made for Claude Code in #1118.Resolves AIGRO-5053.
What to review
editorConfigs.ts:Codex CLInow hasoauthOnly: true;buildCodexCliServerConfigonly writeshttp_headerswhen a token is actually present (matchingdefaultHttpConfig's empty-token handling).Testing
Updated unit tests in
editorConfigs.test.tsandconfigure.test.tsto cover the OAuth-only Codex path. Tests, typecheck, and lint pass.Note
Low Risk
Narrows auth to OAuth for one editor using an existing oauthOnly pattern; reduces stored tokens in local config with no changes to core auth services.
Overview
Codex CLI is now treated as an OAuth-only editor in
sanity mcp configure, matching Cursor and Claude Code. Configure will write only the HTTP MCP server URL/type to~/.codex/config.toml(orCODEX_HOME) and will not mint or embed a Sanity API token inhttp_headersfor fresh setups.buildCodexCliServerConfignow accepts an optional token and only addshttp_headerswhen a token is explicitly provided (e.g. reusing auth from another editor). Tests and the changeset were updated to assert the OAuth-only Codex path and that configure output no longer includes[mcp_servers.Sanity.http_headers]by default.Reviewed by Cursor Bugbot for commit 6ba6ca2. Bugbot is set up for automated code reviews on this repo. Configure here.