Update tone for atl.core, test CLI - #88
Open
BrianAker wants to merge 3 commits into
Open
Conversation
Owner
|
I'll have to investigate this. Thanks for submitting. |
Author
|
With the merge to Sandreas.AudioMetadata I fixed the submodule to use the tip of the GitHub repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If ffmpeg is available this adds a test to see if tone works.
The upstream alt.core library changed how lyrics works so I added a test to check that code path.
If Sandreas.AudioMetadata is updated with the pull request I made and released the gitmodule could be dropped/done a little more eloquently. I did update lang.version and added the dependency for PCRE.NET.
I did not update Microsoft.NETCore.App from 8, I think that should be done but I didn't want to send you too much in a single pull request.
Thank you for writing this app!