Conversation
ef87f1f to
76585a5
Compare
dridzal
approved these changes
Jun 2, 2026
dridzal
left a comment
Collaborator
There was a problem hiding this comment.
At a high level, this looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A flexible augmented Lagrangian (AL) capability.
PolyhedralProjectionnow derives from a newProjectionbase class.Problemhas a newaddConstraintoverload through which users can pass aConstraintandProjectionto implementConstraintcorresponds toProjectioncorresponds to projection onProblemenforces unique constraint names. Users can "group" together collections of constraints for penalization through a newaddConstraintGroupmember ofProblem.The AL framework processes "ungrouped" constraints as follows. (1) Penalize inequalities. (2) Add linear equalities to the subproblem. (3) If present, add nonlinear equalities to the subproblem and penalize bounds. Else, (4) if present, add bounds to the subproblem.
It would help to discuss the following.
Output of the AL algorithm. What is the best way to obtain stationarity measures for the different subproblems?
Default scalings for penalized constraints.