fix(security): upgrade Electron to patch CVE-2024-7971 - #2
Open
cursor[bot] wants to merge 1 commit into
Open
Conversation
Bump electron from ^35.0.0 to ^35.7.5 to ensure installs resolve to a Chromium build that includes the V8 type-confusion fix for CVE-2024-7971 (Chromium >= 128.0.6613.84). Electron 35.7.5 ships Chromium 134.0.6998.205. Verified with npm run build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Patches CVE-2024-7971 (critical V8 type confusion → remote code execution in Chromium renderer) by raising the minimum Electron version from
^35.0.0to^35.7.5.Vulnerability
Analysis
cursorcatsis an Electron desktop app. Renderer windows load local HTML and render agent conversation content (including markdown viamarkedandinnerHTML). While existing hardening (contextIsolation: true,nodeIntegration: false, CSP headers) reduces blast radius, the underlying V8 bug must be patched at the Chromium level.The previous dependency range
^35.0.0allowed npm to resolve to Electron 35.0.0. Electron 35.7.5 ships Chromium 134.0.6998.205, which is well past the patched Chromium 128.0.6613.84 required to fix CVE-2024-7971.Fix
package.jsonelectron:^35.0.0→^35.7.5package-lock.jsonThis is a targeted, minimal change: same Electron major line (35.x), no application code changes.
Verification
npm install— succeedsnpm run build— succeeds (main, preload, and renderer bundles build cleanly)Risk / compatibility