[Fix] Use wrangler project domain for Cloudflare Pages share URLs#50
Merged
Conversation
Resolve the actual Cloudflare Pages domain from wrangler during init
instead of assuming {project_name}.pages.dev, and randomize the default
project name prefix to reduce global name collisions.
## Considered and deferred
- strict-maintainer: old share configs without project_domain now deserialize
with an empty domain and must re-run `recall share init` before publish.
Signed-off-by: samzong <samzong.lu@gmail.com>
samzong
force-pushed
the
fix/share-project-domain
branch
from
66da51a to
19214c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Project Domainsduringrecall share initproject_domaininstead of assuming{project_name}.pages.devProject NameandProject Domainsrecall-xxxxto reduce global name collisionsproject_domainand require re-init before publishWhy
kei-667.pages.devwhen a project name is already taken globally, so hardcoding{project_name}.pages.devproduced broken share links