Add --variants-vcf support for alignments#3
Merged
Merged
Conversation
Support using a variants-only VCF in from-alignments mode to estimate omitted alignment thresholds and exclude non-SNP variant spans. Adds a --variants-vcf CLI flag and a variants_vcf field on AlignmentRunConfig, validation for the VCF path, and a bedtools.subtract helper. Implements VCF parsing utilities (VariantThresholdEstimates, estimate_alignment_thresholds_from_variants_vcf, write_variant_exclusion_bed and helpers) to derive min/max DP from per-sample FORMAT/DP and min MAPQ from INFO/MQ, and to emit exclusion intervals for indels, symbolic SVs, breakends and multi-nucleotide polymorphisms. Integrates threshold resolution and exclusion-bed generation into the workflow (resolve thresholds, write/merge exclusion intervals, subtract exclusions from per-sample pass BEDs). Includes unit tests for the new parsing, CLI, validation, bedtools, and workflow behaviors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support using a variants-only VCF in from-alignments mode to estimate omitted alignment thresholds and exclude non-SNP variant spans. Adds a --variants-vcf CLI flag and a variants_vcf field on AlignmentRunConfig, validation for the VCF path, and a bedtools.subtract helper. Implements VCF parsing utilities (VariantThresholdEstimates, estimate_alignment_thresholds_from_variants_vcf, write_variant_exclusion_bed and helpers) to derive min/max DP from per-sample FORMAT/DP and min MAPQ from INFO/MQ, and to emit exclusion intervals for indels, symbolic SVs, breakends and multi-nucleotide polymorphisms. Integrates threshold resolution and exclusion-bed generation into the workflow (resolve thresholds, write/merge exclusion intervals, subtract exclusions from per-sample pass BEDs). Includes unit tests for the new parsing, CLI, validation, bedtools, and workflow behaviors.