curse+forge fix#46
Open
Stanko2 wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for fixing! Feel free to remove the commented code, no need to keep it around. `resolve_packurl` was for parsing various different URL formats you could get from the curseforge page back in the day. The pack ID was pretty hard to find for users and downloading a zip file is kind of a hassle compared to copying a URL. Some example I was able to copy paste from the page for this random project:
It would be ideal to support as many of these as reasonably possible, but no worries. |
Owner
|
But in general my suggestion would be to use something like https://github.com/gorilla-devs/ferium for mod/modpack management, you can just point it at a picomc instance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the curseforge API to download modpacks. Currently works with supplying
project IDor downloaded zip file. I don't know what exactly the functionresolve_packurlso I uncommented it. Also I could find an endpoint to batch resolveproject_filesso I uncommented that also. The forge-installer URL was broken also so I fixed it.