PLASMA-5874: overlay click handler for Sheet and BottomSheet - #3021
Open
vmytnik wants to merge 2 commits into
Open
PLASMA-5874: overlay click handler for Sheet and BottomSheet#3021vmytnik wants to merge 2 commits into
vmytnik wants to merge 2 commits into
Conversation
vmytnik
requested review from
TitanKuzmich,
Yakutoc,
Yeti-or,
neretin-trike and
shuga2704
as code owners
August 6, 2026 09:46
📝 WalkthroughWalkthroughChangesSheet interaction controls
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant BottomSheetOrSheet
participant useEscKeyDown
participant Callback
User->>BottomSheetOrSheet: press Escape
BottomSheetOrSheet->>useEscKeyDown: process opened and closeOnEsc
useEscKeyDown->>Callback: invoke onEscKeyDown or onClose
User->>BottomSheetOrSheet: click overlay
BottomSheetOrSheet->>Callback: invoke onOverlayClick or onClose
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/plasma-new-hope/src/hooks/useEscKeyDown.ts`:
- Around line 31-37: The useEffect listener registration in useEscKeyDown must
ensure Escape is handled only by the active, topmost sheet. Replace the
per-instance window listener behavior with an active-sheet stack or equivalent
topmost-sheet coordination, so nested sheets do not both invoke onKeyDown for
one key press while preserving cleanup when a sheet closes.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a63db746-ab74-4660-b75e-be66e77a91ad
📒 Files selected for processing (9)
packages/plasma-new-hope/src/components/BottomSheet/BottomSheet.tsxpackages/plasma-new-hope/src/components/BottomSheet/BottomSheet.types.tspackages/plasma-new-hope/src/components/Sheet/Sheet.tsxpackages/plasma-new-hope/src/components/Sheet/Sheet.types.tspackages/plasma-new-hope/src/hooks/index.tspackages/plasma-new-hope/src/hooks/useEscKeyDown.tsutils/api-tests/script.mjsutils/api-tests/src/components/BottomSheet/BottomSheet.api.test.tsxutils/api-tests/src/components/Sheet/Sheet.api.test.tsx
Contributor
|
Theme Builder app deployed! https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-3021/ |
Contributor
Yakutoc
requested review from
IgorYar
and removed request for
Yakutoc,
Yeti-or and
neretin-trike
August 7, 2026 04:32
vmytnik
force-pushed
the
PLASMA-5874.sheet-overlay-click
branch
from
August 7, 2026 12:31
c43e1c8 to
59bd9e9
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/plasma-new-hope/src/hooks/useEscKeyDown.ts`:
- Around line 18-24: Update the stack registration effect in useEscKeyDown so
every opened layer is registered regardless of closeOnEsc. Check whether the
layer is topmost before applying closeOnEsc, and only invoke onClose or
onEscKeyDown when that topmost layer allows Escape handling. Keep closeOnEsc in
callbackRef so prop updates do not remove and re-add the layer.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 51a180c3-5d96-4e6c-8423-134a0d209583
📒 Files selected for processing (1)
packages/plasma-new-hope/src/hooks/useEscKeyDown.ts
vmytnik
force-pushed
the
PLASMA-5874.sheet-overlay-click
branch
from
August 7, 2026 12:48
59bd9e9 to
06245d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core
BottomSheet, Sheet
What/why changed
Summary by CodeRabbit
New Features
Tests
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @salutejs/plasma-asdk@0.387.0-canary.3021.31179775631.0 npm install @salutejs/plasma-b2c@1.629.0-canary.3021.31179775631.0 npm install @salutejs/plasma-colors@0.18.0-canary.3021.31179775631.0 npm install @salutejs/plasma-core@1.236.0-canary.3021.31179775631.0 npm install @salutejs/plasma-giga@0.356.0-canary.3021.31179775631.0 npm install @salutejs/plasma-homeds@0.356.0-canary.3021.31179775631.0 npm install @salutejs/plasma-hope@1.383.0-canary.3021.31179775631.0 npm install @salutejs/plasma-icons@1.245.0-canary.3021.31179775631.0 npm install @salutejs/plasma-new-hope@0.373.0-canary.3021.31179775631.0 npm install @salutejs/plasma-tokens@1.147.0-canary.3021.31179775631.0 npm install @salutejs/plasma-tokens-b2b@1.61.0-canary.3021.31179775631.0 npm install @salutejs/plasma-tokens-b2c@0.72.0-canary.3021.31179775631.0 npm install @salutejs/plasma-tokens-core@0.9.0-canary.3021.31179775631.0 npm install @salutejs/plasma-tokens-web@1.76.0-canary.3021.31179775631.0 npm install @salutejs/plasma-typo@0.49.0-canary.3021.31179775631.0 npm install @salutejs/plasma-web@1.631.0-canary.3021.31179775631.0 npm install @salutejs/sdds-bizcom@0.361.0-canary.3021.31179775631.0 npm install @salutejs/sdds-cs@0.365.0-canary.3021.31179775631.0 npm install @salutejs/sdds-dfa@0.359.0-canary.3021.31179775631.0 npm install @salutejs/sdds-finai@0.352.0-canary.3021.31179775631.0 npm install @salutejs/sdds-insol@0.356.0-canary.3021.31179775631.0 npm install @salutejs/sdds-insol-next@0.355.0-canary.3021.31179775631.0 npm install @salutejs/sdds-netology@0.360.0-canary.3021.31179775631.0 npm install @salutejs/sdds-os@0.31.0-canary.3021.31179775631.0 npm install @salutejs/sdds-platform-ai@0.360.0-canary.3021.31179775631.0 npm install @salutejs/sdds-sbcom@0.361.0-canary.3021.31179775631.0 npm install @salutejs/sdds-scan@0.359.0-canary.3021.31179775631.0 npm install @salutejs/sdds-serv@0.360.0-canary.3021.31179775631.0 npm install @salutejs/core-themes@0.37.0-canary.3021.31179775631.0 npm install @salutejs/plasma-themes@0.59.0-canary.3021.31179775631.0 npm install @salutejs/sdds-themes@0.74.0-canary.3021.31179775631.0 npm install @salutejs/sdds-api-tests@0.18.0-canary.3021.31179775631.0 npm install @salutejs/plasma-cy-utils@0.166.0-canary.3021.31179775631.0 npm install @salutejs/plasma-sb-utils@0.237.0-canary.3021.31179775631.0 npm install @salutejs/plasma-tokens-utils@0.57.0-canary.3021.31179775631.0 # or yarn add @salutejs/plasma-asdk@0.387.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-b2c@1.629.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-colors@0.18.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-core@1.236.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-giga@0.356.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-homeds@0.356.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-hope@1.383.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-icons@1.245.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-new-hope@0.373.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-tokens@1.147.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-tokens-b2b@1.61.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-tokens-b2c@0.72.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-tokens-core@0.9.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-tokens-web@1.76.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-typo@0.49.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-web@1.631.0-canary.3021.31179775631.0 yarn add @salutejs/sdds-bizcom@0.361.0-canary.3021.31179775631.0 yarn add @salutejs/sdds-cs@0.365.0-canary.3021.31179775631.0 yarn add @salutejs/sdds-dfa@0.359.0-canary.3021.31179775631.0 yarn add @salutejs/sdds-finai@0.352.0-canary.3021.31179775631.0 yarn add @salutejs/sdds-insol@0.356.0-canary.3021.31179775631.0 yarn add @salutejs/sdds-insol-next@0.355.0-canary.3021.31179775631.0 yarn add @salutejs/sdds-netology@0.360.0-canary.3021.31179775631.0 yarn add @salutejs/sdds-os@0.31.0-canary.3021.31179775631.0 yarn add @salutejs/sdds-platform-ai@0.360.0-canary.3021.31179775631.0 yarn add @salutejs/sdds-sbcom@0.361.0-canary.3021.31179775631.0 yarn add @salutejs/sdds-scan@0.359.0-canary.3021.31179775631.0 yarn add @salutejs/sdds-serv@0.360.0-canary.3021.31179775631.0 yarn add @salutejs/core-themes@0.37.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-themes@0.59.0-canary.3021.31179775631.0 yarn add @salutejs/sdds-themes@0.74.0-canary.3021.31179775631.0 yarn add @salutejs/sdds-api-tests@0.18.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-cy-utils@0.166.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-sb-utils@0.237.0-canary.3021.31179775631.0 yarn add @salutejs/plasma-tokens-utils@0.57.0-canary.3021.31179775631.0