Skip to content

PLASMA-7299: Note ContentBefore align - #3012

Open
vmytnik wants to merge 6 commits into
devfrom
PLASMA-7299
Open

PLASMA-7299: Note ContentBefore align#3012
vmytnik wants to merge 6 commits into
devfrom
PLASMA-7299

Conversation

@vmytnik

@vmytnik vmytnik commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Core

Note

  • добавлен токен для вертикального выравнивания ContentBefore

PLASMA-HOMEDS

Note

  • размеры и отступы в соответствии с новым макетом
  • оставил только size M
  • вертикальное выравнивание ContentBefore посередине
  • кастомные размеры для иконки ContentBefore и текста ActionContent

PLASMA-SB-UTILS

Note

  • добавил возможность указать кастомные размеры для иконки ContentBefore и текста ActionContent

What/why changed

Summary by CodeRabbit

New Features

  • Added improved Note sizing with a streamlined medium-size configuration.
  • Enhanced Note layout support for vertical and horizontal orientations.
  • Added flexible alignment for leading content, including improved vertical centering.

Bug Fixes

  • Improved consistency between Note content, icons, and action links.
  • Updated icon sizing behavior for scalable and fixed-size Notes.
  • Refined typography, spacing, and padding across Note layouts.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-asdk@0.387.0-canary.3012.31100719700.0
npm install @salutejs/plasma-b2c@1.629.0-canary.3012.31100719700.0
npm install @salutejs/plasma-colors@0.18.0-canary.3012.31100719700.0
npm install @salutejs/plasma-core@1.236.0-canary.3012.31100719700.0
npm install @salutejs/plasma-giga@0.356.0-canary.3012.31100719700.0
npm install @salutejs/plasma-homeds@0.356.0-canary.3012.31100719700.0
npm install @salutejs/plasma-hope@1.383.0-canary.3012.31100719700.0
npm install @salutejs/plasma-icons@1.245.0-canary.3012.31100719700.0
npm install @salutejs/plasma-new-hope@0.373.0-canary.3012.31100719700.0
npm install @salutejs/plasma-tokens@1.147.0-canary.3012.31100719700.0
npm install @salutejs/plasma-tokens-b2b@1.61.0-canary.3012.31100719700.0
npm install @salutejs/plasma-tokens-b2c@0.72.0-canary.3012.31100719700.0
npm install @salutejs/plasma-tokens-core@0.9.0-canary.3012.31100719700.0
npm install @salutejs/plasma-tokens-web@1.76.0-canary.3012.31100719700.0
npm install @salutejs/plasma-typo@0.49.0-canary.3012.31100719700.0
npm install @salutejs/plasma-web@1.631.0-canary.3012.31100719700.0
npm install @salutejs/sdds-bizcom@0.361.0-canary.3012.31100719700.0
npm install @salutejs/sdds-cs@0.365.0-canary.3012.31100719700.0
npm install @salutejs/sdds-dfa@0.359.0-canary.3012.31100719700.0
npm install @salutejs/sdds-finai@0.352.0-canary.3012.31100719700.0
npm install @salutejs/sdds-insol@0.356.0-canary.3012.31100719700.0
npm install @salutejs/sdds-insol-next@0.355.0-canary.3012.31100719700.0
npm install @salutejs/sdds-netology@0.360.0-canary.3012.31100719700.0
npm install @salutejs/sdds-os@0.31.0-canary.3012.31100719700.0
npm install @salutejs/sdds-platform-ai@0.360.0-canary.3012.31100719700.0
npm install @salutejs/sdds-sbcom@0.361.0-canary.3012.31100719700.0
npm install @salutejs/sdds-scan@0.359.0-canary.3012.31100719700.0
npm install @salutejs/sdds-serv@0.360.0-canary.3012.31100719700.0
npm install @salutejs/core-themes@0.37.0-canary.3012.31100719700.0
npm install @salutejs/plasma-themes@0.59.0-canary.3012.31100719700.0
npm install @salutejs/sdds-themes@0.74.0-canary.3012.31100719700.0
npm install @salutejs/sdds-api-tests@0.18.0-canary.3012.31100719700.0
npm install @salutejs/plasma-cy-utils@0.166.0-canary.3012.31100719700.0
npm install @salutejs/plasma-sb-utils@0.237.0-canary.3012.31100719700.0
npm install @salutejs/plasma-tokens-utils@0.57.0-canary.3012.31100719700.0
# or 
yarn add @salutejs/plasma-asdk@0.387.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-b2c@1.629.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-colors@0.18.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-core@1.236.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-giga@0.356.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-homeds@0.356.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-hope@1.383.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-icons@1.245.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-new-hope@0.373.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-tokens@1.147.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-tokens-b2b@1.61.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-tokens-b2c@0.72.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-tokens-core@0.9.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-tokens-web@1.76.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-typo@0.49.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-web@1.631.0-canary.3012.31100719700.0
yarn add @salutejs/sdds-bizcom@0.361.0-canary.3012.31100719700.0
yarn add @salutejs/sdds-cs@0.365.0-canary.3012.31100719700.0
yarn add @salutejs/sdds-dfa@0.359.0-canary.3012.31100719700.0
yarn add @salutejs/sdds-finai@0.352.0-canary.3012.31100719700.0
yarn add @salutejs/sdds-insol@0.356.0-canary.3012.31100719700.0
yarn add @salutejs/sdds-insol-next@0.355.0-canary.3012.31100719700.0
yarn add @salutejs/sdds-netology@0.360.0-canary.3012.31100719700.0
yarn add @salutejs/sdds-os@0.31.0-canary.3012.31100719700.0
yarn add @salutejs/sdds-platform-ai@0.360.0-canary.3012.31100719700.0
yarn add @salutejs/sdds-sbcom@0.361.0-canary.3012.31100719700.0
yarn add @salutejs/sdds-scan@0.359.0-canary.3012.31100719700.0
yarn add @salutejs/sdds-serv@0.360.0-canary.3012.31100719700.0
yarn add @salutejs/core-themes@0.37.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-themes@0.59.0-canary.3012.31100719700.0
yarn add @salutejs/sdds-themes@0.74.0-canary.3012.31100719700.0
yarn add @salutejs/sdds-api-tests@0.18.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-cy-utils@0.166.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-sb-utils@0.237.0-canary.3012.31100719700.0
yarn add @salutejs/plasma-tokens-utils@0.57.0-canary.3012.31100719700.0

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Note component now uses medium sizing in Homeds, updated typography and orientation styles, and configurable leading-content alignment. Shared Storybook utilities centralize icon-size resolution and support configurable LinkButton sizing.

Changes

Note sizing, layout, and Storybook behavior

Layer / File(s) Summary
Note style contract and layout
packages/plasma-new-hope/src/components/Note/Note.tokens.ts, packages/plasma-new-hope/src/components/Note/variations/_size/base.ts, packages/plasma-homeds/src/components/Note/Note.config.ts
The Note styles add contentBeforeAlignSelf, apply it to ContentBefore, and update Homeds size, typography, spacing, padding, and orientation rules.
Note story size resolution
utils/plasma-sb-utils/src/components/Note/fixtures.ts, utils/plasma-sb-utils/src/components/Note/Note.tsx, utils/plasma-sb-utils/src/components/Note/stories.tsx
Story utilities centralize icon-size mapping and accept configurable icon and LinkButton sizes.
Homeds Storybook configuration
packages/plasma-homeds/src/components/Note/Note.stories.tsx
Homeds stories use medium defaults, configured icon and LinkButton sizes, and disabled size controls.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: yakutoc, igoryar, oki1oki

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding alignment support for the Note ContentBefore element.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch PLASMA-7299

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-3012/

@Yakutoc
Yakutoc requested review from IgorYar and oki1oki and removed request for Yeti-or, neretin-trike and shuga2704 August 3, 2026 14:29
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Documentation preview deployed!

website: https://plasma.sberdevices.ru/pr/pr-3012/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-3012/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-3012/b2c-storybook/
giga storybook: https://plasma.sberdevices.ru/pr/pr-3012/giga-storybook/
homeds storybook: https://plasma.sberdevices.ru/pr/pr-3012/homeds-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-3012/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-3012/web-storybook/
sdds-bizcom storybook: https://plasma.sberdevices.ru/pr/pr-3012/sdds-bizcom-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-3012/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-3012/sdds-dfa-storybook/
sdds-finai storybook: https://plasma.sberdevices.ru/pr/pr-3012/sdds-finai-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-3012/sdds-insol-storybook/
sdds-insol-next storybook: https://plasma.sberdevices.ru/pr/pr-3012/sdds-insol-next-storybook/
sdds-netology storybook: https://plasma.sberdevices.ru/pr/pr-3012/sdds-netology-storybook/
sdds-os storybook: https://plasma.sberdevices.ru/pr/pr-3012/sdds-os-storybook/
sdds-platform-ai storybook: https://plasma.sberdevices.ru/pr/pr-3012/sdds-platform-ai-storybook/
sdds-sbcom storybook: https://plasma.sberdevices.ru/pr/pr-3012/sdds-sbcom-storybook/
sdds-scan storybook: https://plasma.sberdevices.ru/pr/pr-3012/sdds-scan-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-3012/sdds-serv-storybook/

Comment thread packages/plasma-new-hope/src/components/Note/variations/_size/base.ts Outdated
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@Yakutoc
Yakutoc requested review from TitanKuzmich and removed request for Yakutoc August 7, 2026 04:31
@vmytnik
vmytnik requested a review from luizasok August 7, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants