PLASMA-7716: JS tokens audit (sdds-cs) - #3009
Conversation
📝 WalkthroughWalkthroughChangesThe PR replaces legacy styling references with imported theme tokens across SDDS-CS components. It removes the deprecated Progress Theme and component configuration updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Theme Builder app deployed! https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-3009/ |
|
Documentation preview deployed! website: https://plasma.sberdevices.ru/pr/pr-3009/ |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/sdds-cs/src/components/Skeleton/LineSkeleton.config.ts`:
- Around line 32-33: Add the missing CSS declaration separator after
skeletonTokens.gradientColor in the Skeleton configuration so the subsequent
fadeInColor declaration parses independently and preserves the default fade-in
styling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: dc35d0d8-2167-490e-9d14-88f290790ec2
⛔ Files ignored due to path filters (22)
cypress/snapshots/cs/chromium/Autocomplete/Autocomplete -- readOnly.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/chromium/Combobox/Combobox -- readOnly.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/chromium/Select/Select -- chipView=default multiselect.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/chromium/Select/Select -- closeAfterSelect.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/chromium/Select/Select -- optional, innerLabel.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/chromium/Select/Select -- required=left, noLabel.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/chromium/Select/Select -- view=default, size=s, labelPlacement=inner.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/chromium/TextField/TextField -- view=default, size=m appearance=clear,hasDivider=true.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/chromium/TextField/TextField -- view=default, size=m.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/chromium/TextField/TextField -- view=negative, size=s appearance=clear,hasDivider=true.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/chromium/TextField/TextField -- view=negative, size=s.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/webkit/Autocomplete/Autocomplete -- readOnly.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/webkit/Combobox/Combobox -- readOnly.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/webkit/Select/Select -- closeAfterSelect.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/webkit/Select/Select -- optional, innerLabel.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/webkit/Select/Select -- required=left, noLabel.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/webkit/Select/Select -- view=default, size=s, labelPlacement=inner.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/webkit/Skeleton/Skeleton -- withSkeleton -- simple.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/webkit/TextField/TextField -- view=default, size=m appearance=clear,hasDivider=true.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/webkit/TextField/TextField -- view=default, size=m.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/webkit/TextField/TextField -- view=negative, size=s appearance=clear,hasDivider=true.snap.pngis excluded by!**/*.pngcypress/snapshots/cs/webkit/TextField/TextField -- view=negative, size=s.snap.pngis excluded by!**/*.png
📒 Files selected for processing (16)
packages/sdds-cs/src/components/Autocomplete/Autocomplete.config.tspackages/sdds-cs/src/components/Badge/Badge.config.common.tspackages/sdds-cs/src/components/Calendar/Calendar.config.tspackages/sdds-cs/src/components/Calendar/CalendarDouble.config.tspackages/sdds-cs/src/components/Combobox/Combobox.config.tspackages/sdds-cs/src/components/Dropdown/Dropdown.config.tspackages/sdds-cs/src/components/Progress/Progress.config.tspackages/sdds-cs/src/components/Select/Select.config.tspackages/sdds-cs/src/components/Skeleton/LineSkeleton.config.tspackages/sdds-cs/src/components/Spinner/Spinner.stories.tsxpackages/sdds-cs/src/components/Tabs/horizontal/HorizontalTabItem.config.tspackages/sdds-cs/src/components/TextArea/TextArea.clear.config.tspackages/sdds-cs/src/components/TextArea/TextArea.config.tspackages/sdds-cs/src/components/TextField/TextField.clear.config.tspackages/sdds-cs/src/components/TextField/TextField.config.tswebsite/sdds-cs-docs/docs/components/Progress.mdx
💤 Files with no reviewable changes (3)
- packages/sdds-cs/src/components/Progress/Progress.config.ts
- website/sdds-cs-docs/docs/components/Progress.mdx
- packages/sdds-cs/src/components/Dropdown/Dropdown.config.ts
SDDS-CS
What/why changed
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @salutejs/plasma-asdk@0.384.1-canary.3009.30805481614.0 npm install @salutejs/plasma-b2c@1.626.1-canary.3009.30805481614.0 npm install @salutejs/plasma-colors@0.16.1-canary.3009.30805481614.0 npm install @salutejs/plasma-core@1.233.1-canary.3009.30805481614.0 npm install @salutejs/plasma-giga@0.353.1-canary.3009.30805481614.0 npm install @salutejs/plasma-homeds@0.353.1-canary.3009.30805481614.0 npm install @salutejs/plasma-hope@1.380.1-canary.3009.30805481614.0 npm install @salutejs/plasma-icons@1.243.1-canary.3009.30805481614.0 npm install @salutejs/plasma-new-hope@0.370.1-canary.3009.30805481614.0 npm install @salutejs/plasma-tokens@1.145.1-canary.3009.30805481614.0 npm install @salutejs/plasma-tokens-b2b@1.59.1-canary.3009.30805481614.0 npm install @salutejs/plasma-tokens-b2c@0.70.1-canary.3009.30805481614.0 npm install @salutejs/plasma-tokens-core@0.7.1-canary.3009.30805481614.0 npm install @salutejs/plasma-tokens-web@1.74.1-canary.3009.30805481614.0 npm install @salutejs/plasma-typo@0.47.1-canary.3009.30805481614.0 npm install @salutejs/plasma-web@1.628.1-canary.3009.30805481614.0 npm install @salutejs/sdds-bizcom@0.358.1-canary.3009.30805481614.0 npm install @salutejs/sdds-cs@0.362.1-canary.3009.30805481614.0 npm install @salutejs/sdds-dfa@0.356.1-canary.3009.30805481614.0 npm install @salutejs/sdds-finai@0.349.1-canary.3009.30805481614.0 npm install @salutejs/sdds-insol@0.353.1-canary.3009.30805481614.0 npm install @salutejs/sdds-insol-next@0.353.1-canary.3009.30805481614.0 npm install @salutejs/sdds-netology@0.357.1-canary.3009.30805481614.0 npm install @salutejs/sdds-os@0.28.1-canary.3009.30805481614.0 npm install @salutejs/sdds-platform-ai@0.357.1-canary.3009.30805481614.0 npm install @salutejs/sdds-sbcom@0.358.1-canary.3009.30805481614.0 npm install @salutejs/sdds-scan@0.356.1-canary.3009.30805481614.0 npm install @salutejs/sdds-serv@0.357.1-canary.3009.30805481614.0 npm install @salutejs/core-themes@0.35.1-canary.3009.30805481614.0 npm install @salutejs/plasma-themes@0.57.1-canary.3009.30805481614.0 npm install @salutejs/sdds-themes@0.71.1-canary.3009.30805481614.0 npm install @salutejs/sdds-api-tests@0.15.1-canary.3009.30805481614.0 npm install @salutejs/plasma-cy-utils@0.163.1-canary.3009.30805481614.0 npm install @salutejs/plasma-sb-utils@0.234.1-canary.3009.30805481614.0 npm install @salutejs/plasma-tokens-utils@0.55.1-canary.3009.30805481614.0 # or yarn add @salutejs/plasma-asdk@0.384.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-b2c@1.626.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-colors@0.16.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-core@1.233.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-giga@0.353.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-homeds@0.353.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-hope@1.380.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-icons@1.243.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-new-hope@0.370.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-tokens@1.145.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-tokens-b2b@1.59.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-tokens-b2c@0.70.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-tokens-core@0.7.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-tokens-web@1.74.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-typo@0.47.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-web@1.628.1-canary.3009.30805481614.0 yarn add @salutejs/sdds-bizcom@0.358.1-canary.3009.30805481614.0 yarn add @salutejs/sdds-cs@0.362.1-canary.3009.30805481614.0 yarn add @salutejs/sdds-dfa@0.356.1-canary.3009.30805481614.0 yarn add @salutejs/sdds-finai@0.349.1-canary.3009.30805481614.0 yarn add @salutejs/sdds-insol@0.353.1-canary.3009.30805481614.0 yarn add @salutejs/sdds-insol-next@0.353.1-canary.3009.30805481614.0 yarn add @salutejs/sdds-netology@0.357.1-canary.3009.30805481614.0 yarn add @salutejs/sdds-os@0.28.1-canary.3009.30805481614.0 yarn add @salutejs/sdds-platform-ai@0.357.1-canary.3009.30805481614.0 yarn add @salutejs/sdds-sbcom@0.358.1-canary.3009.30805481614.0 yarn add @salutejs/sdds-scan@0.356.1-canary.3009.30805481614.0 yarn add @salutejs/sdds-serv@0.357.1-canary.3009.30805481614.0 yarn add @salutejs/core-themes@0.35.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-themes@0.57.1-canary.3009.30805481614.0 yarn add @salutejs/sdds-themes@0.71.1-canary.3009.30805481614.0 yarn add @salutejs/sdds-api-tests@0.15.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-cy-utils@0.163.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-sb-utils@0.234.1-canary.3009.30805481614.0 yarn add @salutejs/plasma-tokens-utils@0.55.1-canary.3009.30805481614.0Summary by CodeRabbit
Bug Fixes
Documentation
Style