⚡ Bolt: Optimize ArtifactStore.gc with batched operations#335
⚡ Bolt: Optimize ArtifactStore.gc with batched operations#335google-labs-jules[bot] wants to merge 2 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
💡 What: Replaced sequential
fs.statandfs.rmoperations inArtifactStore.gcwith batched concurrent operations usingPromise.alland a chunk size of 10. Added a removal queue for deletions instead of mixing state calculation and deletions.🎯 Why: Sequential operations over many files cause significant performance bottlenecks and hit EMFILE limits. Doing deletions in the state calculation loop can lead to race conditions.
📊 Impact: Reduces garbage collection latency significantly when handling many artifact files, prevents EMFILE crashes, and avoids race conditions during space reclamation calculation.
🔬 Measurement: Can be verified by running the test suite (
bun run test:full) to ensure no regressions, and observing improved artifact GC performance under load.PR created automatically by Jules for task 422276515347463281 started by @YoungSx