Skip to content

⚡ Bolt: Optimize ArtifactStore.gc with batched operations#335

Open
google-labs-jules[bot] wants to merge 2 commits into
mainfrom
bolt-optimize-artifact-gc-422276515347463281
Open

⚡ Bolt: Optimize ArtifactStore.gc with batched operations#335
google-labs-jules[bot] wants to merge 2 commits into
mainfrom
bolt-optimize-artifact-gc-422276515347463281

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

💡 What: Replaced sequential fs.stat and fs.rm operations in ArtifactStore.gc with batched concurrent operations using Promise.all and a chunk size of 10. Added a removal queue for deletions instead of mixing state calculation and deletions.
🎯 Why: Sequential operations over many files cause significant performance bottlenecks and hit EMFILE limits. Doing deletions in the state calculation loop can lead to race conditions.
📊 Impact: Reduces garbage collection latency significantly when handling many artifact files, prevents EMFILE crashes, and avoids race conditions during space reclamation calculation.
🔬 Measurement: Can be verified by running the test suite (bun run test:full) to ensure no regressions, and observing improved artifact GC performance under load.


PR created automatically by Jules for task 422276515347463281 started by @YoungSx

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants