⚡ Bolt: [performance improvement] Optimize artifact garbage collection I/O#325
⚡ Bolt: [performance improvement] Optimize artifact garbage collection I/O#325google-labs-jules[bot] wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
💡 What: Refactored
ArtifactStore.gcto use batched, concurrent operations (Promise.allwith a chunk size of 10) for evaluating file stats and deleting expired artifacts.🎯 Why: The original implementation awaited
fs.statandfs.rmsequentially inside a loop. When processing a high volume of artifacts, this creates a severe I/O bottleneck that slows down garbage collection and monopolizes the event loop. Concurrent batching processes files much faster without hittingEMFILElimits.📊 Impact: Significantly reduces GC phase duration for projects with many artifacts by parallelizing I/O.
🔬 Measurement: Run the internal artifact store tests (
bun test tests/unit/sub-agent/artifacts/ArtifactStore.test.ts). The optimized code retains exact functional equivalence while enabling the JS engine to dispatch multiple fs calls to the underlying thread pool simultaneously.PR created automatically by Jules for task 18314623730833482496 started by @YoungSx