fix(chat): decouple layout loading state from blocking mask visibility#68
Open
google-labs-jules[bot] wants to merge 4 commits into
Open
Conversation
Currently, the `ChatConversationSurfaceStatePresenter` misuses `IsLayoutLoading` to directly force the visibility of the `BlockingLoadingMask` and `LoadingOverlayPresenter` regardless of the actual activation intent or remote hydration progress. This causes a visual regression where the UI forces an artificial blocking mask over stale content merely because `IsLayoutLoading` has temporarily pulsed, violating the rule that layout-loading state should not be misused as a fake visible overlay in places that should depend on actual presenter visibility. This patch decouples `ShouldShowBlockingLoadingMask` and `ShouldShowLoadingOverlayPresenter` from `shouldPromoteLayoutLoadingToBlockingPresenter` (and removes it entirely), allowing the actual authoritative activation overlay states to drive visibility independently of the monotonic layout realization cycle. A new unit test `Resolve_LayoutLoadingState_DoesNotOverrideVisibilityState` is added to enforce this invariant. Verification: - `dotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --no-restore --filter-class SalmonEgg.Presentation.Core.Tests.Chat.Overlay.ChatConversationSurfaceStatePresenterTests` (Passed) - `dotnet test --solution SalmonEgg.sln --configuration Debug --no-build` (Passed)
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Currently, the ChatConversationSurfaceStatePresenter misuses IsLayoutLoading to directly force the visibility of the BlockingLoadingMask and LoadingOverlayPresenter regardless of the actual activation intent or remote hydration progress. This causes a visual regression where the UI forces an artificial blocking mask over stale content merely because IsLayoutLoading has temporarily pulsed, violating the rule that layout-loading state should not be misused as a fake visible overlay in places that should depend on actual presenter visibility. This patch decouples ShouldShowBlockingLoadingMask and ShouldShowLoadingOverlayPresenter from shouldPromoteLayoutLoadingToBlockingPresenter (and removes it entirely), allowing the actual authoritative activation overlay states to drive visibility independently of the monotonic layout realization cycle. A new unit test Resolve_LayoutLoadingState_DoesNotOverrideVisibilityState is added to enforce this invariant. It also fixes flaky tests in WASM smoke gate, and avoids broken pipe caused by yes when calling sdkmanager. Verification: - dotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --no-restore --filter-class SalmonEgg.Presentation.Core.Tests.Chat.Overlay.ChatConversationSurfaceStatePresenterTests (Passed) - dotnet test --solution SalmonEgg.sln --configuration Debug --no-build (Passed)
Currently, the ChatConversationSurfaceStatePresenter misuses IsLayoutLoading to directly force the visibility of the BlockingLoadingMask and LoadingOverlayPresenter regardless of the actual activation intent or remote hydration progress. This causes a visual regression where the UI forces an artificial blocking mask over stale content merely because IsLayoutLoading has temporarily pulsed, violating the rule that layout-loading state should not be misused as a fake visible overlay in places that should depend on actual presenter visibility. This patch decouples ShouldShowBlockingLoadingMask and ShouldShowLoadingOverlayPresenter from shouldPromoteLayoutLoadingToBlockingPresenter (and removes it entirely), allowing the actual authoritative activation overlay states to drive visibility independently of the monotonic layout realization cycle. A new unit test Resolve_LayoutLoadingState_DoesNotOverrideVisibilityState is added to enforce this invariant. It also fixes flaky tests in WASM smoke gate, and avoids broken pipe caused by yes when calling sdkmanager. Verification: - dotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --no-restore --filter-class SalmonEgg.Presentation.Core.Tests.Chat.Overlay.ChatConversationSurfaceStatePresenterTests (Passed) - dotnet test --solution SalmonEgg.sln --configuration Debug --no-build (Passed)
Currently, the ChatConversationSurfaceStatePresenter misuses IsLayoutLoading to directly force the visibility of the BlockingLoadingMask and LoadingOverlayPresenter regardless of the actual activation intent or remote hydration progress. This causes a visual regression where the UI forces an artificial blocking mask over stale content merely because IsLayoutLoading has temporarily pulsed, violating the rule that layout-loading state should not be misused as a fake visible overlay in places that should depend on actual presenter visibility. This patch decouples ShouldShowBlockingLoadingMask and ShouldShowLoadingOverlayPresenter from shouldPromoteLayoutLoadingToBlockingPresenter (and removes it entirely), allowing the actual authoritative activation overlay states to drive visibility independently of the monotonic layout realization cycle. A new unit test Resolve_LayoutLoadingState_DoesNotOverrideVisibilityState is added to enforce this invariant. It also fixes flaky tests in WASM smoke gate, and avoids broken pipe caused by yes when calling sdkmanager. Verification: - dotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --no-restore --filter-class SalmonEgg.Presentation.Core.Tests.Chat.Overlay.ChatConversationSurfaceStatePresenterTests (Passed) - dotnet test --solution SalmonEgg.sln --configuration Debug --no-build (Passed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChatConversationSurfaceStatePresentermisused theIsLayoutLoadingproperty to force theBlockingLoadingMaskandLoadingOverlayPresenterto appear. This caused a fake visible overlay that incorrectly masked the UI whenever layout-loading pulsed, violating the rule that layout-loading state should not override actual presenter visibility.shouldPromoteLayoutLoadingToBlockingPresenterwas being computed and directly combined with the authoritative blocking states via|| shouldPromoteLayoutLoadingToBlockingPresenter, incorrectly coupling monotonic layout realization to visual state.shouldPromoteLayoutLoadingToBlockingPresenter), ensuring that the blocking masks strictly evaluate authoritative hydration and activation intent without being falsely triggered by layout phases. No private state machines were introduced.dotnet test --project tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --no-restore --filter-class SalmonEgg.Presentation.Core.Tests.Chat.Overlay.ChatConversationSurfaceStatePresenterTestsdotnet test --solution SalmonEgg.sln --configuration Debug --no-buildShouldShow...boolean projections was verified synchronously.PR created automatically by Jules for task 13273309580228214746 started by @YoungSx