Fix latest-intent checking in ChatConversationSurfaceStatePresenter#66
Fix latest-intent checking in ChatConversationSurfaceStatePresenter#66google-labs-jules[bot] wants to merge 1 commit into
Conversation
When a rapid session switch occurs and the shell registers a new `PendingShellActivationConversationId`, the current session may still be in the `IsConnecting` or `IsInitializing` state. Because `ResolveOverlayLoadingStage` checks `isConnecting` and `isInitializing` before `shellActivationIntentVisible`, the loading overlay incorrectly displayed "Connecting..." or "Initializing Protocol..." (the state of the old, superseded session) instead of "Preparing Session..." (the state of the new, latest intent). This change updates `ResolveOverlayLoadingStage` to prioritize checking for session switch intents by evaluating `sessionSwitchOverlayVisible`, `sessionSwitchPreviewVisible`, and `isSessionSwitchOverlayBlockingVisibleTranscript` earlier, satisfying the latest-intent correctness constraint. Added `ChatConversationSurfaceStatePresenterTests_LatestIntent` regression test to cover this specific scenario.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
When a rapid session switch occurs and the shell registers a new
PendingShellActivationConversationId, the current session may still be in theIsConnectingorIsInitializingstate. BecauseResolveOverlayLoadingStagechecksisConnectingandisInitializingbeforeshellActivationIntentVisible, the loading overlay incorrectly displayed "Connecting..." or "Initializing Protocol..." (the state of the old, superseded session) instead of "Preparing Session..." (the state of the new, latest intent).This change updates
ResolveOverlayLoadingStageto prioritize checking for session switch intents by evaluatingsessionSwitchOverlayVisible,sessionSwitchPreviewVisible, andisSessionSwitchOverlayBlockingVisibleTranscriptearlier, satisfying the latest-intent correctness constraint.Added
ChatConversationSurfaceStatePresenterTests_LatestIntentregression test to cover this specific scenario.Verification run:
dotnet build SalmonEgg.sln --configuration Debugdotnet test tests/SalmonEgg.Presentation.Core.Tests/SalmonEgg.Presentation.Core.Tests.csproj --configuration Debug --no-restorePR created automatically by Jules for task 5399136658914776772 started by @YoungSx