Fix secondary highlight handling for partial selections - #117
Merged
Conversation
Require exact single-span selections for secondary highlights and preserve adjacent or inline ranges during snapshot restore. Refs #115
githubSINGLE
approved these changes
Aug 18, 2026
githubSINGLE
left a comment
Collaborator
There was a problem hiding this comment.
all things look good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
updateSelectionToolbar()treated anyRange.intersectsNode()result as a full highlight match, soapplySelectionHighlight()recolored the entire span and discarded the saved range. Boundary-only contact also counted as overlap. Highlight restore additionally assigned seam offsets to the preceding text node and did not expand fully selected inline boundaries, causing adjacent or inline ranges to be lost.Impact
Partial or cross-boundary selections no longer recolor unselected text or create nested highlights. Complete primary-highlight selections still promote to secondary, and resulting highlight levels survive snapshot/restore.
Validation
node developer/tests/js/readingInteractionRegression.test.jsnpm test --prefix developer(72 tests)python -m unittest discover -s developer/tests/py -p "test_*.py"(20 tests)python developer/tests/ci/check_reading_data_integrity.pypython developer/tests/e2e/e2e_runner.pynode scripts/build-bundles.mjs --checkgit diff --checkFixes #115