Fail springboot builds when their validation checks fail#280
Fail springboot builds when their validation checks fail#280thirtyseven wants to merge 1 commit into
Conversation
|
Thanks for the contribution! Before we can merge this, we need @thirtyseven to sign the Salesforce Inc. Contributor License Agreement. |
…ecks fail Add comment Fix filenames
|
@thirtyseven sorry for the delay on this. A contribution (not yours) since 2.6.3 breaks our internal monorepo, and I just haven't had time to sort out the solution. I am trying to get through it this weekend. |
|
No worries! This is technically a breaking change too, although I’d imagine for most users a welcome one. Should it be gated behind an attr and/or a CLI flag? |
Perhaps the flag won't be necessary if the plan is to bump the major version as indicated here: #282 (comment) |
2 participants
This PR adds a _validation output group to the springboot rule that includes the outputs of dupecheck, javaxdetect and banneddeps. This ensures that the springboot build fails when these checks fail.
The PR also changes the generated validation files to have unique filenames. This addresses some cases for "multiple springboot rules in the same package" that were not handled in #139.