fix(auth): handle production login errors via Astro ActionError - #99
Merged
Conversation
- Replace generic native Error with Astro's `ActionError` utility - Set the error code explicitly to `UNAUTHORIZED` for production safety - Improve error message clarity for incorrect credential submissions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR addresses a critical production routing issue where failed authentication credentials threw generic JavaScript errors, disrupting client-side notification routing. It transitions the validation failure mechanism to a secure, explicit Astro error schema.
Key Changes:
throw new Error()check with an explicit AstroActionErrorobject.UNAUTHORIZEDruntime code block to ensure predictable status headers and client-side handling under Cloudflare production edge deployments.Fixes # (issue number)
🧪 Type of Change
🛠️ How Has This Been Tested?
Verified credential rejection states locally within development runtime configurations.
Inspected execution logs to guarantee that client-side
useActioncatch blocks handle the descriptive string error message accurately without swallowing the response object.Unit/Integration tests added/passed
Local manual edge verification successful
📸 Screenshots / Diffs (if applicable)
Modified File:
src/modules/auth/auth.actions.ts✅ Checklist