refactor(auth): modularize login hook and remove duplicate schema - #98
Merged
Conversation
- Rename and relocate `use-log-in.ts` hook to `modules/auth/auth.hooks.ts` - Remove deprecated global `src/schema/login.ts` file - Fix state naming mismatch in `LogInForm` component (`isPending` -> `isLoading`) - Update import mappings to use local module schemas and hooks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR finalizes the architectural co-location of the authentication module. It shifts the login state hook directly into the auth domain and eliminates legacy global files to prevent structural drift.
Key Changes:
src/hooks/use-log-in.tsintosrc/modules/auth/auth.hooks.tsto keep feature hooks local.src/schema/login.tsin favor of the unifiedsrc/modules/auth/auth.schema.ts.LogInFormUI component to use the localized hook imports and swapped out the variable references fromisPendingtoisLoadingto match the coreuseActionhook interface.Fixes # (issue number)
🧪 Type of Change
🛠️ How Has This Been Tested?
Verified local authentication form input handling against the updated
auth.schema.tsrules.Confirmed submission UI states (Loading spinners and active/disabled buttons) toggle smoothly using the aligned
isLoadingstate.Checked project compilation to ensure no broken or stale import path aliases remain.
Unit/Integration tests added/passed
Local manual edge verification successful
📸 Screenshots / Diffs (if applicable)
File tracking:
Deleted:src/schema/login.tsMoved & Updated:src/hooks/use-log-in.ts➔src/modules/auth/auth.hooks.tsUpdated:src/modules/auth/components/login.tsx✅ Checklist