fix(auth): drop explicit cookie domain to resolve edge deployment drops - #103
Merged
Conversation
- Remove explicit `domain` assignment from the `auth_token` cookie configuration - Allow the browser to fall back to default host origin matching for the custom domain - Restore the `maxAge` explanatory comment string for structural readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR resolves the core production authentication failure where the browser completely failed to write the session cookie.
Key Changes:
domain: context.url.hostnameconfiguration constraint from theauth_tokencookie properties. This prevents Cloudflare Pages proxy routes from causing cross-domain cookie rejections, allowing the browser to fall back to natural matching rules on your live custom domain.Fixes # (issue number)
🧪 Type of Change
🛠️ How Has This Been Tested?
Verified that removing the explicit domain declaration allows modern browser security engines to safely set the context token header automatically under the root origin.
Unit/Integration tests added/passed
Local manual edge verification successful
📸 Screenshots / Diffs (if applicable)
Modified File:
src/modules/auth/auth.actions.ts✅ Checklist