Skip to content

Scrub stale bitsentry alias during install #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rywils merged 2 commits into from
Aug 16, 2026
Merged

Scrub stale bitsentry alias during install #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3c36f1
Scrub stale bitsentry shell alias during install
rywils Aug 16, 2026
9d7d103
Only auto-remove provably standalone bitsentry aliases
rywils Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions scripts/install_bitsentry.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,35 @@ else
fi
rm -f "${LAUNCHER_TMP}"

# A shell alias named `bitsentry` (e.g. left over from an older version of
# this installer, or copied in via synced dotfiles from another machine)
# shadows the real launcher in interactive shells even though this script
# -- running under bash -- has no visibility into zsh/fish alias tables to
# detect that itself. Scrub it from the rc file we're about to manage so
# "install completed" actually means the command works.
#
# Only delete a line if it's PROVABLY just a standalone `alias bitsentry=...`
# declaration -- the whole line, nothing else. A line sharing `; other-cmd`,
# `&& other-cmd`, a leading conditional, or a trailing `\` continuation gets
# left alone; deleting the whole line would silently destroy that unrelated
# content too. Those get reported for manual cleanup instead.
BITSENTRY_ALIAS_RE='alias[[:space:]]+bitsentry='
BITSENTRY_ALIAS_STANDALONE_RE='^[[:space:]]*alias[[:space:]]+bitsentry=("[^"]*"|'"'"'[^'"'"']*'"'"'|[^[:space:];&|\\]+)[[:space:]]*$'
if [[ -n "${RC_FILE}" ]] && [[ -f "${RC_FILE}" ]] && grep -qE "${BITSENTRY_ALIAS_RE}" "${RC_FILE}"; then
if grep -qE "${BITSENTRY_ALIAS_STANDALONE_RE}" "${RC_FILE}"; then
echo "[!] Found an existing 'bitsentry' alias in ${RC_FILE} that would shadow the installed launcher."
if [[ "${OS_NAME}" == "Darwin" ]]; then
sed -i '' -E "/${BITSENTRY_ALIAS_STANDALONE_RE}/d" "${RC_FILE}"
else
sed -i -E "/${BITSENTRY_ALIAS_STANDALONE_RE}/d" "${RC_FILE}"
fi
echo "[+] Removed stale bitsentry alias from ${RC_FILE}"
fi
if grep -qE "${BITSENTRY_ALIAS_RE}" "${RC_FILE}"; then
echo "[!] ${RC_FILE} still defines a 'bitsentry' alias on a compound, conditional, or continued line -- it may shadow the installed launcher. Please remove it manually."
fi
fi

if [[ "${OS_NAME}" == "Darwin" ]] && [[ "${INSTALL_BIN_PATH}" == *"/sbin/"* ]]; then
MAC_BIN="/usr/local/bin/bitsentry"
if [[ ! -f "${MAC_BIN}" ]] || [[ "${INSTALL_BIN_PATH}" -nt "${MAC_BIN}" ]] 2>/dev/null; then
Expand Down
Loading