Skip to content

test(journal): pin bare + agent-prefixed NODE_OPTIONS banner collapse (#1093) #4979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rysweet wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(journal): pin bare + agent-prefixed NODE_OPTIONS banner collapse (#1093) #4979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/journal/tests_pr_source.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,31 @@ fn plain_summary_drops_node_options_launcher_banner_title() {
To change: /home/azureuser/.amplihack/config",
);
assert_eq!(fix, "A code change.", "banner leaked into journal: {fix}");

// Bare banner with NO Conventional-Commits prefix: the first colon lives in
// the trailing `To change:` path, so `strip_conventional_prefix` is a no-op
// and the whole banner reaches `strip_recipe_noise` — it must still collapse.
let bare = plainify_pr_title(
"\u{2139} NODE_OPTIONS=--max-old-space-size=32768 (saved preference). \
To change: /home/azureuser/.amplihack/config",
);
assert_eq!(
bare, "A code change.",
"bare banner leaked into journal: {bare}"
);

// Banner still wearing the recipe-runner per-agent log prefix
// (`[HH:MM:SS] [amplihack:copilot:PID] …`), which `strip_recipe_noise`
// peels before applying the launcher-line predicate.
let prefixed = plainify_pr_title(
"[08:26:10] [amplihack:copilot:460198] \u{2139} \
NODE_OPTIONS=--max-old-space-size=32768 (saved preference). \
To change: /home/azureuser/.amplihack/config",
);
assert_eq!(
prefixed, "A code change.",
"agent-prefixed banner leaked into journal: {prefixed}"
);
}

/// Anti-weakening guard (issue #1093): the filter must match the launcher banner
Expand Down
Loading