Skip to content

Fix/rescue pawn#907

Merged
notfood merged 5 commits intorwmt:devfrom
Sakura-TA:fix/rescue-pawn
May 8, 2026
Merged

Fix/rescue pawn#907
notfood merged 5 commits intorwmt:devfrom
Sakura-TA:fix/rescue-pawn

Conversation

@Sakura-TA
Copy link
Copy Markdown
Contributor

Use TargetMethods to prevent missing patch

@notfood notfood added fix Fixes for a bug or desync. 1.6 Fixes or bugs relating to 1.6 (Not Odyssey). labels May 8, 2026
@notfood notfood moved this to In review in 1.6 and Odyssey May 8, 2026
@notfood
Copy link
Copy Markdown
Member

notfood commented May 8, 2026

Aren't they the same?

@mibac138
Copy link
Copy Markdown
Member

mibac138 commented May 8, 2026

According to the docs, it looks like when you use multiple [HarmonyPatch] attributes, they are merged into one (so I think it's a coin toss which method will be patched), and the actual supported way to do this is by using TargetMethods. See here

@notfood notfood merged commit c58202a into rwmt:dev May 8, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from In review to Done in 1.6 and Odyssey May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.6 Fixes or bugs relating to 1.6 (Not Odyssey). fix Fixes for a bug or desync.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants