Conversation
added 5 commits
April 20, 2026 18:05
…event quest site tile divergence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is to cache the gravship search result wisely.
default in vanilla, a redo of search is happening when one of the following situation is matched:
Means in the following situation it always do the search and iter through all the items:
This patch use cache to prevent all-item-iter happens in these 3 situation.
It's working fine to me for now and fixed the problems I mentioned here, but I believe further works is still available on it, like "check the gravship's ownership" or "make 2 ships on same map clearly independent", So I'll draft this PR here for a little while before I'm sure with what should be added here, and also for a longer test.