Open
Conversation
added 5 commits
April 20, 2026 18:05
…event quest site tile divergence
Member
|
It doesn't need to be dynamic. Isn't this preferable? [HarmonyPatch(typeof(Map), nameof(Map.IsPlayerHome), MethodType.Getter)] |
Contributor
Author
|
Absolutely yes, I was testing with patching AnyPlayerHome but then decide to change my direction and cut into IsPlayerHome, which left it here. |
notfood
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is to make all map isPlayerHome check returns if it's any player's home instead of check for spectator's home.
Currently when ticking world componets we fall back to Spectator as factioncontext.
Here's my vision on this check, or on world component tick since normally only this situation the context would fall to spectator.
The side reason for me to make this patch is that search for AnyPlayerHome in worldcomponent of spectator will drop to search for gravengine in all the maps, which always iter through all-map-all-things and can cause laggy if AnyPlayerHome is used frequently.