Correct docs to reflect new log_level names in post-tracing Rocket - #3007
Open
mcclure wants to merge 1 commit into
Open
Correct docs to reflect new log_level names in post-tracing Rocket#3007mcclure wants to merge 1 commit into
mcclure wants to merge 1 commit into
Conversation
Specifically, off/critical/normal/debug are now off/error/warn/info/debug/trace, and the defaults are now info/error instead of normal/critical.
4 tasks
|
Thank you for the patch - I had already addressed most of these issues on my fork (rustfoo/rkt@a6aaece - went in a while ago, but my git foo is bad this morning I re-wrote the history fixing a typo) But you have highlighted a few areas that I missed. Your patch is not directly applicable to my fork as I have moved a lot of things around - also the banner blocks have changed significantly - I have created a new PR incorporating those fixes here rustfoo/rkt#20. |
Author
|
All right— in case we are eventually able to get hold of the original Rocket maintainer, are there additional documentation fixes from your fork I should try to port back into this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 0.5.1, the log levels are "off", "normal", "debug", and "critical". In current
master, due to adoption of thetracingcrate, they are "off", "error", "warn", "info", "debug", "trace", or 0-5. This is not currently reflected in the documentation. (Which is bad, because if you check outmasterand follow the documentation currently in thedocs/folder, you will set your log_level to "normal" or "critical", and the program will fail to boot.) Patch addresses this.Quirks of patch:
log_level. I don't know what strings these correspond to, so I didn't try to document them. I will fix this if you ask.infoanddebugare now separate log levels.