Skip to content

fix: hide raw tool output and edit saved connections#78

Merged
rusty4444 merged 1 commit into
mainfrom
fix/issues-75-76-77-mobile-chat-connections
Jul 18, 2026
Merged

fix: hide raw tool output and edit saved connections#78
rusty4444 merged 1 commit into
mainfrom
fix/issues-75-76-77-mobile-chat-connections

Conversation

@rusty4444

Copy link
Copy Markdown
Owner

Summary

Fixes the new open mobile issues by addressing both the chat rendering bug and saved connection editing:

  • hide persisted tool-result messages with broader role/content detection instead of rendering them as full chat bubbles
  • strip embedded <untrusted_tool_result> blocks from assistant text if a server payload contains mixed assistant/tool content
  • normalise nested JSON-escaped \\n/\\r\\n sequences into real line breaks before passing content to MarkdownBody
  • add an Edit Connection menu item that reuses the connection dialog pre-filled with the current host, port, API key, gateway prefix, dashboard settings, and credentials
  • preserve the existing connection id/list position when editing, and keep HTTPS connections pre-filled as https://host so they do not accidentally downgrade to HTTP

Fixes #75
Fixes #76
Fixes #77

Verification

  • flutter analyze
  • flutter test

@rusty4444

Copy link
Copy Markdown
Owner Author

Hermes Agent automated review

Verdict: approved for direct merge (own PR; GitHub blocks formal self-review).

Review notes:

  • Verified the diff for lib/core/utils/message_content.dart, lib/core/screens/chat_screen.dart, lib/core/services/connection_manager.dart, lib/main.dart, and the new tests.
  • The tool-result filtering is broader than role-only detection and keeps user-visible assistant text by storing _display_content separately.
  • The connection edit flow preserves connection id/list position and correctly normalizes HTTPS host/port handling through SavedConnection.normalizeHostAndPort.
  • Added tests cover updateConnection, escaped newline normalization, and raw Hermes tool-result stripping.

Local verification run by Hermes Agent:

  • flutter pub get
  • flutter test ✅ — 42 tests passed
  • flutter analyze ✅ — No issues found

CI gate rechecked before this comment: non-draft, MERGEABLE, one reported check (Analyze & Test) with SUCCESS.

@rusty4444
rusty4444 merged commit de18cc0 into main Jul 18, 2026
1 check passed
@rusty4444
rusty4444 deleted the fix/issues-75-76-77-mobile-chat-connections branch July 18, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant