Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds focused regression coverage for the recent output format selection work in
crates/cli/src/commands/mod.rs.The current command resolution logic supports explicit
--formatoverrides on top of command-specific defaults, but the test suite only covered the default structured and human behaviors plus--jsonprecedence. That left two recently added branches unexercised: forcing human output for a structured-default command, and forcing auto-detection for a human-default command.Root cause
The output-mode feature introduced multiple resolution paths in
GlobalOutputOptions::resolve, but only part of the decision matrix had direct unit coverage. Without tests for the remaining override branches, a later refactor could silently regress explicit--formathandling even while the existing default-path tests continued to pass.Fix
I added two unit tests that pin those branches explicitly:
explicit_human_overrides_structured_defaultexplicit_auto_overrides_human_defaultThese tests keep the scope tight to the recent output-format feature and avoid changing production code.
Validation
The repository does not currently define a
make pre-committarget, so I ran the equivalent CI checks directly from the repository workflow instead:cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspace