Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions crates/s3/src/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3172,6 +3172,17 @@ mod tests {
assert!(request.headers().get("x-rustfs-force-delete").is_none());
}

#[tokio::test]
async fn delete_object_wrapper_uses_default_options_without_rustfs_header() {
let (client, request_receiver) = test_s3_client(None);
let path = RemotePath::new("test", "bucket", "key.txt");

let _ = ObjectStore::delete_object(&client, &path).await;

let request = request_receiver.expect_request();
assert!(request.headers().get("x-rustfs-force-delete").is_none());
}

#[tokio::test]
async fn delete_objects_with_force_delete_sets_rustfs_header() {
let response = http::Response::builder()
Expand All @@ -3195,6 +3206,23 @@ mod tests {
assert_eq!(request.headers().get("x-rustfs-force-delete"), Some("true"));
}

#[tokio::test]
async fn delete_objects_wrapper_uses_default_options_without_rustfs_header() {
let response = http::Response::builder()
.status(200)
.body(SdkBody::from(
r#"<?xml version="1.0" encoding="UTF-8"?>
<DeleteResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/" />"#,
))
.expect("build delete objects response");
let (client, request_receiver) = test_s3_client(Some(response));

let _ = ObjectStore::delete_objects(&client, "bucket", vec!["key.txt".to_string()]).await;

let request = request_receiver.expect_request();
assert!(request.headers().get("x-rustfs-force-delete").is_none());
}

#[tokio::test]
async fn read_next_part_fills_buffer_until_eof() {
use tokio::io::AsyncWriteExt;
Expand Down