Skip to content

Support InstaNovo schemas through v1.2.2#97

Merged
douweschulte merged 2 commits into
rusteomics:mainfrom
BioGeek:instanovo-1.2.2
Jun 22, 2026
Merged

Support InstaNovo schemas through v1.2.2#97
douweschulte merged 2 commits into
rusteomics:mainfrom
BioGeek:instanovo-1.2.2

Conversation

@BioGeek

@BioGeek BioGeek commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This PR updates mzident InstaNovo import support from the existing v1.1.4 coverage through InstaNovo v1.2.2.

Changes:

  • Adds explicit InstaNovo version handling for v1.1.0, v1.1.4, and v1.2.2.
  • Adds support for InstaNovo+ v1.2.2 and combined v1.2.2 prediction outputs.
  • Tightens schema detection so transformer, diffusion, and combined outputs are disambiguated correctly.
  • Handles empty token log probability columns where valid for InstaNovo+ outputs.
  • Updates CV term/file-format mapping for the new supported versions.
  • Adds focused prediction fixtures derived from sample prediction files

Tested with:

cargo test -p mzident instanovo --no-fail-fast

Result: 7 passed; 0 failed

Existing workspace warnings are unchanged and unrelated to this PR.

Note: the CI fails but that is due to an unrelated error. See #98 for a fix.

@douweschulte douweschulte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the additions! It is very nice to get some insight from the authors for parsing these files. Also thanks a lot for the included example files with the source given. I will add some very small touch ups directly after merging, on the column detection and version detection, but otherwise it looks perfect.

@douweschulte douweschulte merged commit 2224f63 into rusteomics:main Jun 22, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants