Skip to content

Clean up various things for Keyboard v2 - #2800

Merged
kchibisov merged 4 commits into
rust-windowing:kchibisov-keyboard-v2from
bread-graphics:keyboard-v2-cleanup
May 14, 2023
Merged

Clean up various things for Keyboard v2#2800
kchibisov merged 4 commits into
rust-windowing:kchibisov-keyboard-v2from
bread-graphics:keyboard-v2-cleanup

Conversation

@notgull

@notgull notgull commented May 11, 2023

Copy link
Copy Markdown
Contributor
  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

Various cleanups for Keyboard V2 (#2789):

  • Use the build constants for the platforms.
  • Make sure memmap2 is at the latest version and is actually imported.
  • Run rustfmt.
  • Add documentation for KeyCodeExtScancode.

@kchibisov

Copy link
Copy Markdown
Member

The wayland backend hasn't been updated yet, so I'm not sure wrt that PR yet. Will keep it around for a while.

@notgull

notgull commented May 11, 2023

Copy link
Copy Markdown
Contributor Author

The wayland backend hasn't been updated yet, so I'm not sure wrt that PR yet. Will keep it around for a while.

I see. Would you like me to take a crack at updating it for Wayland?

@kchibisov

Copy link
Copy Markdown
Member

I'll do that given that it's simple, but I just don't have time at the moment. You can update x11's xkb handling and I just use it, given both use common infra.

@notgull
notgull force-pushed the keyboard-v2-cleanup branch from 3998969 to ef944e8 Compare May 14, 2023 18:27
@notgull

notgull commented May 14, 2023

Copy link
Copy Markdown
Contributor Author

I removed the changes to the Wayland from this PR.

@kchibisov
kchibisov merged commit b165571 into rust-windowing:kchibisov-keyboard-v2 May 14, 2023
@notgull
notgull deleted the keyboard-v2-cleanup branch May 14, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants